-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] SEF: Enable new SEF options for new installations #43024
Conversation
shouldnt the default value in the xml match the value being set in the install sql? |
No, because the default for existing installations should be the current behavior, not the new behavior. If I set the default to the value in the installation SQL, then a user editing the SEF plugin, not changing anything and then saving would have the new behavior. |
I have tested this item ✅ successfully on d03b7bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024. |
I have tested this item ✅ successfully on f64664b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024. |
Thanks @Hackwar ! |
Summary of Changes
This PR enables the new SEF features for new installations by default. It also changes the value of the trailingslash option. In Joomla 6.0 we want to remove the "Do nothing" option again and it would be stupid to then have to switch between the values 1 and 2 instead of 0 and 1.
Testing Instructions
Codereview?
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed