Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Cassiopeia back to top #43057

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[4.4] Cassiopeia back to top #43057

merged 1 commit into from
Mar 18, 2024

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #42312 .

Summary of Changes

When enabled the back to top button should be visible as soon as you have scrolled

Testing Instructions

Apply pr and run npm build:css or use a prebuilt package in this pr

In the cassiopeia template style enable the back to top button

In the front end test on a short page (no scrolling possible) and a long page (with scrolling)

Expected result BEFORE applying this Pull Request

back to top button is not present on the short page
back to top button is visible on the long page only when you have reached the very bottom of the page

Expected result AFTER applying this Pull Request

back to top button is not present on the short page
back to top button is visible on the long page as soon as you start scrolling and disapears as soon as you scroll nack to the top

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Mar 16, 2024

I have tested this item ✅ successfully on b0e9dad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43057.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on b0e9dad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43057.

@Quy
Copy link
Contributor

Quy commented Mar 17, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43057.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 17, 2024
@laoneo laoneo merged commit 828c236 into joomla:4.4-dev Mar 18, 2024
4 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 18, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 18, 2024
@laoneo laoneo added this to the Joomla! 4.4.4 milestone Mar 18, 2024
@brianteeman brianteeman deleted the back_to_top branch March 18, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants