-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [PHP8.4] Update for nullable type declaration #43323
Merged
laoneo
merged 15 commits into
joomla:5.2-dev
from
heelc29:5.1/php84/implicitly-nullable-parameter
Aug 6, 2024
Merged
[5.2] [PHP8.4] Update for nullable type declaration #43323
laoneo
merged 15 commits into
joomla:5.2-dev
from
heelc29:5.1/php84/implicitly-nullable-parameter
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been automatically rebased to 5.2-dev. |
HLeithner
changed the title
[5.1][PHP8.4][WIP] Update for nullable type declaration
[5.2] [PHP8.4][WIP] Update for nullable type declaration
Apr 24, 2024
heelc29
changed the title
[5.2] [PHP8.4][WIP] Update for nullable type declaration
[5.2] [PHP8.4] Update for nullable type declaration
Apr 25, 2024
heelc29
requested review from
bembelimen,
HLeithner,
rdeutz and
zero-24
as code owners
April 25, 2024 19:17
heelc29
force-pushed
the
5.1/php84/implicitly-nullable-parameter
branch
from
June 30, 2024 17:23
74dad8b
to
02fe995
Compare
HLeithner
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
updates for https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Testing Instructions
at the moment no QA release of PHP8.4 ... so only code review (and phpcs by drone)PHP 8.4.0 Alpha 1 available for testingActual result BEFORE applying this Pull Request
Warning:
Expected result AFTER applying this Pull Request
No new deprecated warnings (excepted composer dependencies) if update to PHP8.4
Link to documentations
Please select: