Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][Events] Use event classes for Authentication plugins #43601

Merged
merged 9 commits into from
Aug 29, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 2, 2024

Summary of Changes

Update authentication and api-authentication plugins to use SubscriberInterface and an event classes.

Testing Instructions

Login/Logout,
do API request.

All should work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: New Event classes Manual#177
  • No documentation changes for manual.joomla.org needed

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on 9825e5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43601.

@exlemor
Copy link

exlemor commented Aug 24, 2024

I have tested this item ✅ successfully on 9825e5a

Hi, thanks to @LadySolveig, and @bembelimen, I was able to successfully test this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43601.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43601.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@Hackwar Hackwar enabled auto-merge (squash) August 29, 2024 07:41
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 29, 2024
@Hackwar
Copy link
Member

Hackwar commented Aug 29, 2024

Thank you for your contribution @Fedik!

@Hackwar Hackwar merged commit 22cb27a into joomla:5.2-dev Aug 29, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2024
@Fedik Fedik deleted the plg-event-auth branch August 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants