Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] [Events] Use event classes for custom fields plugins #43611

Merged
merged 13 commits into from
Oct 10, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 3, 2024

Summary of Changes

Update fields plugins to use SubscriberInterface and event classes.

Testing Instructions

Create/edit custom fields, all should work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: New Event classes Manual#177
  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Jul 23, 2024

I have tested this item ✅ successfully on 6295367

I created a Textarea field, a radio button field, Media (image) and it worked perfectly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.

@Frostholm7
Copy link

I have tested this item ✅ successfully on 6295367

with new installation with 5.1 dev and 5.2 dev
Have I tested
New Group
New Subfild
New calendar
New Articles
Filled in the new fields
Saved
Checked logs
everything ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.

@Quy
Copy link
Contributor

Quy commented Aug 8, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 8, 2024
@Hackwar
Copy link
Member

Hackwar commented Aug 29, 2024

I'm not convinced that the subform field works and since none of the testers claimed to have tested that, I'd like to wait with merging.

@exlemor
Copy link

exlemor commented Aug 29, 2024

@Hackwar - I just retested it with the subform field... Here is a screenshot:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.

@exlemor
Copy link

exlemor commented Aug 29, 2024

Here it is (had to use GitHub, Joomla Issue Tracker wouldn't let me add the image :/

The subform field appears at the top and the regular custom field on the bottom.

for-PR-43611-for-Hackwar

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2][Events] Use event classes for custom fields plugins [5.3] [Events] Use event classes for custom fields plugins Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@laoneo laoneo merged commit 26ac214 into joomla:5.3-dev Oct 10, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 10, 2024
@laoneo
Copy link
Member

laoneo commented Oct 10, 2024

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Oct 10, 2024
@Fedik Fedik deleted the plg-event-media-fields branch October 10, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants