-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Add onchange option to modal-select form field #43618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not use inline javascript anymore |
Sure, but as long as we have this option everywhere else, we should also keep it consistent. |
I have tested this item ✅ successfully on 992cc09 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43618. |
1 similar comment
I have tested this item ✅ successfully on 992cc09 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43618. |
Quy
added
the
NPM Resource Changed
This Pull Request can't be tested by Patchtester
label
Jun 18, 2024
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43618. |
joomla-cms-bot
removed
the
NPM Resource Changed
This Pull Request can't be tested by Patchtester
label
Jun 18, 2024
Thanks. @Hackwar could you do a PR to deprecate all this inline stuff and think about a proper implementation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I noticed that the layout of the modal-select form field declares the $onchange option, but does not use it. This PR fixes that. I'm not sure if this is a new feature or a bugfix, since it fixes a broken behavior, but could also be judged as a new feature? I created it for 5.1 for now.
Testing Instructions
Edit a filter form like
administrator/components/com_content/forms/filter_articles.xml
and add a modal select field here. One example would be the following:(You have to add
addfieldprefix="Joomla\Component\Content\Administrator\Field"
to the<fieldset>
of that XML, too.)Go to the article list view in the backend and select an article from the modal.
Actual result BEFORE applying this Pull Request
Article is selected, nothing happens otherwise.
Expected result AFTER applying this Pull Request
Article is selected, the filter form is submitted and the page is reloading. (Since there is no filter for this on the server side, the request doesn't change anything, but the onchange event is properly fired.)
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed