Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix radio and checkboxes in nested subform field #43660

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 15, 2024

Pull Request for Issue #40160

Summary of Changes

Fix radio and checkboxes in nested subform field

Testing Instructions

Run npm install.

Add following XML for subform field, somewhere, example in Custom HTML module.
And check that Radio buttons and Checkboxes works.

<field type="subform" name="subform" label="subform" multiple="true">
    <form>
        <field type="text" name="text" label="Text" />
        <field name="radioTop" type="radio" label="Radio top">
            <option value="0">JNO</option>
            <option value="1">JYES</option>
        </field>
        <field name="check" type="checkboxes" label="Checkboxes">
            <option value="0">JNO</option>
            <option value="1">JYES</option>
        </field>
        <field name="checkOne" type="checkbox" label="Checkbox"/>

        <field type="subform" name="nested_subform" label="nested subform" multiple="true">
            <form>
                <field type="text" name="nested_text" label="Nested Text" />
                <field name="radioNested" type="radio" label="Nested Radio">
                    <option value="0">JNO</option>
                    <option value="1">JYES</option>
                </field>
                <field name="checkNested" type="checkboxes" label="Nested checkboxes">
                    <option value="0">JNO</option>
                    <option value="1">JYES</option>
                </field>
                <field name="checkOneNested" type="checkbox" label="Nested Checkbox"/>
            </form>
        </field>
    </form>
</field>

Actual result BEFORE applying this Pull Request

Radio buttons and checkboxes in nested subform does not get checked when click on its label.

Expected result AFTER applying this Pull Request

All radio buttons and checkboxes works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Jun 15, 2024
@Fedik Fedik added the bug label Jun 15, 2024
@RickR2H
Copy link
Member

RickR2H commented Jun 28, 2024

I have tested this item ✅ successfully on ff2e65c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43660.

@LadySolveig LadySolveig added this to the Joomla! 5.1.2 milestone Jul 3, 2024
@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on 0d69a50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43660.

@bembelimen bembelimen merged commit 870486c into joomla:5.1-dev Jul 3, 2024
2 of 4 checks passed
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants