[5.1] Cypress com_cache joomla dialog fix #43682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedik
reviewed
Jun 20, 2024
| it('can clear expired cache', () => { | ||
| cy.get('#toolbar-delete2').click(); | ||
| cy.get('body').then(($body) => { | ||
| if ($body.find('div.buttons-holder button[data-button-ok]').length > 0) { |
There was a problem hiding this comment.
For joomla 5 there a command clickDialogConfirm
joomla-cms/tests/System/support/commands.js
Lines 16 to 17 in 7f710fb
it used in many places already, like:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fix for Cypress test for com_cache 5.1 for com_cache from 5.1 and upwards like suggested here by @muhme #43633 (comment)
Testing Instructions
Review and passing tests
Actual result BEFORE applying this Pull Request
Tests pass
Expected result AFTER applying this Pull Request
Tests pass
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed