Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] If RSS feed is blocked, don't allow access to RSS output #43692

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jun 22, 2024

Summary of Changes

Right now we have the ability to disable the RSS link in the header of different views, however that only hides the link in the output. You can still access the RSS output when simply typing in the URL. This PR disables the output when the link is disabled.

Testing Instructions

Go to any view which also provides a feed output and open the options for its menu item or change the the global configuration of the component to disable showing the feed link.

Actual result BEFORE applying this Pull Request

You can still access the output of the RSS feed.

Expected result AFTER applying this Pull Request

You get a 404 "Resource not found" result.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@webnet-assmann
Copy link

I have tested this item ✅ successfully on 3c50bfc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43692.

@fgsw
Copy link

fgsw commented Aug 1, 2024

@Hackwar Is a test useful even "This branch is out-of-date with the base branch"?

@brianteeman
Copy link
Contributor

@Hackwar Is a test useful even "This branch is out-of-date with the base branch"?

as long as there are no conflicts then yes

@fgsw
Copy link

fgsw commented Aug 1, 2024

I have tested this item ✅ successfully on 3c50bfc

Test on a multilingual site.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43692.

@fgsw
Copy link

fgsw commented Aug 3, 2024

Ready To Commit?

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Aug 3, 2024
@pe7er pe7er self-assigned this Aug 8, 2024
@pe7er pe7er enabled auto-merge (squash) August 8, 2024 20:20
@pe7er pe7er merged commit aaac490 into joomla:5.2-dev Aug 8, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 8, 2024
@pe7er
Copy link
Contributor

pe7er commented Aug 8, 2024

Thanks @Hackwar !

@Quy Quy added this to the Joomla! 5.2.0 milestone Aug 8, 2024
@Hackwar Hackwar deleted the 5.2-rss branch August 12, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants