-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Field ModalSelect: make sure token in the URLs #43745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.1-dev
labels
Jul 6, 2024
I have tested this item ✅ successfully on 9b02403 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745. |
1 similar comment
I have tested this item ✅ successfully on 9b02403 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745. |
I have tested this item ✅ successfully on 1b734cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745. |
Thank you @Fedik and also for testing @Quy @viocassel @robbiejackson ! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fix for the ModalSelect field, always add the token to the urls.
Testing Instructions
Run
npm install
Add ModalSelect field in to Custom HTML module XML:
Then open Custom HTML module editing on the site (not administrator). And try to select the article, using "select" button.
Actual result BEFORE applying this Pull Request
An error, kind of "wrong token"
Expected result AFTER applying this Pull Request
All works, you should be able to select the article
Link to documentations
Please select: