Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix Fontend language multilingual without compatibility plugin #43791

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Jul 14, 2024

Summary of Changes

Fix wrong field name for multilingual sites in user profile

Testing Instructions

  • Disable the "Behaviour - Backward Compatibility" plugin
  • Enable the "System - Language Filter" plugin
  • Check User profile (frontend/backend)

Actual result BEFORE applying this Pull Request

  • Language field is a text field

Expected result AFTER applying this Pull Request

  • Language field is a select

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on a1a927a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43791.

@richard67
Copy link
Member

@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32

@dautrich
Copy link

I have tested this item ✅ successfully on a1a927a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43791.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43791.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 14, 2024
@bembelimen
Copy link
Contributor Author

@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32

Should not have any effect on it

@richard67
Copy link
Member

@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32

Should not have any effect on it

@bembelimen Should it be changed to public $type = 'Frontendlanguage'; in 6.0-dev so it is like for the other fields? Or should that $type variable be deprecated for all fields because it has no effect at all?

@brianteeman
Copy link
Contributor

@bembelimen Do you know what this is good for, and is it somehow related to the issue? https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/Form/Field/FrontendlanguageField.php#L26-L32

Should not have any effect on it

@bembelimen Should it be changed to public $type = 'Frontendlanguage'; in 6.0-dev so it is like for the other fields? Or should that $type variable be deprecated for all fields because it has no effect at all?

it confused me

@LadySolveig LadySolveig added this to the Joomla! 5.1.3 milestone Jul 26, 2024
@LadySolveig LadySolveig merged commit b1a759d into joomla:5.1-dev Jul 26, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2024
@LadySolveig
Copy link
Contributor

Thanks @bembelimen and also for testing and review @brianteeman @dautrich @richard67

dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants