[5.1] Update bump script also to update package-lock.json #43801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @HLeithner |
Quy
reviewed
Jul 17, 2024
|
I have tested this item ✅ successfully on eba833d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801. |
|
I have tested this item ✅ successfully on eba833d Thanks!!!! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801. |
|
(I got a php fatal error on line 313 BUT i ran it on windows and I seem to recall the script will not run on windows and that part of the file is not part of this PR and the parts in this PR all completed correctly) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801. |
|
I tested it and it worked on linux, also line 313 is only a preg_replace so shouldn't fail |
|
Thank you @brianteeman and @richard67 for testing! |
dgrammatiko
suggested changes
Jul 17, 2024
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
|
Thanks @dgrammatiko |
dgrammatiko
suggested changes
Jul 18, 2024
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* Update bump script also to update package-lock.json --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Quy <quy@nomonkeybiz.com> Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* Update bump script also to update package-lock.json --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Quy <quy@nomonkeybiz.com> Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43743 .
Summary of Changes
Also update the package-lock.json on version bump
Testing Instructions
php build/bump.php -v 5.2.3
Actual result BEFORE applying this Pull Request
package.json is updated
package-lock.json is not updated
Expected result AFTER applying this Pull Request
package.json is updated
package-lock.json is updated