Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Delete schemaorg item after deleting an item #43839

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jul 24, 2024

Pull Request for Issue #43830 .

Summary of Changes

Added a onContentAfterDelete event to the schmea org Plugin

Testing Instructions

see issue #43830

Actual result BEFORE applying this Pull Request

The schemaorg entry remains orphaned in the database

Expected result AFTER applying this Pull Request

The schemaorg entry is deleted with the item

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

chmst and others added 2 commits July 24, 2024 14:13
Co-authored-by: jsanders <j53.sanders@gmail.com>
@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on c0e319c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43839.

@bembelimen bembelimen changed the title delete schemaorg item after deleting an item [5.1] Delete schemaorg item after deleting an item Jul 24, 2024
@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on c0e319c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43839.

@bembelimen bembelimen merged commit 6d7d276 into joomla:5.1-dev Jul 25, 2024
4 checks passed
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.3 milestone Jul 25, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants