Don't execute max system tests on pr commits #43846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeutz
approved these changes
Jul 25, 2024
|
Sorry I know I wasn't on the maintainer call where this was discussed as was travelling. Whilst definitely behind this. I do think we should be testing PRs on a PHP max so we can test for PHP notices/warnings/errors. So my suggestion would be keep the spirit of only running two and do php max + mysql and php min + postgres (can be reversed but you get the gist) |
|
Implemented the idea from @wilsonge . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Don't execute max system tests on pr commits. This will reduce resource usage on the drone server.