Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolbar for mail-template as other layouts #43849

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jul 25, 2024

Pull Request for Issue # .

Summary of Changes

The layout of the mail-template differs from other layouts.

Testing Instructions

Look at the mail-template screen before and after patch, make sure the buttons work as before and as expected.

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

Took me a while to see the problem. For reference the save button is always a single button and any other save buttons are a dropdown group

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7ec72da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43849.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jul 25, 2024

I have tested this item ✅ successfully on 7ec72da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43849.

@Quy
Copy link
Contributor

Quy commented Jul 25, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43849.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 25, 2024
@chmst
Copy link
Contributor Author

chmst commented Jul 26, 2024

Took me a while to see the problem. For reference the save button is always a single button and any other save buttons are a dropdown group

Thank you for testing. I most cases, there is a drop down button group, but sometimes the buttons are single buttons, see configuration or view levels, where no other actions are possible.

@Hackwar Hackwar merged commit 7f48923 into joomla:5.2-dev Jul 26, 2024
4 checks passed
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Jul 26, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2024
@Hackwar
Copy link
Member

Hackwar commented Jul 26, 2024

Thank you @chmst for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants