[4.4] Fix missing $db->quoteName in FieldLayoutField #43851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Quy
reviewed
Jul 26, 2024
administrator/components/com_fields/src/Field/FieldLayoutField.php
Outdated
Show resolved
Hide resolved
….php Co-authored-by: Quy <quy@nomonkeybiz.com>
|
I have tested this item ✅ successfully on e9a6d1b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43851. |
1 similar comment
|
I have tested this item ✅ successfully on e9a6d1b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43851. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43851. |
richard67
approved these changes
Jul 28, 2024
|
Thank you! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* Fix missing quoteName in FieldLayoutField * remove empty space * Update administrator/components/com_fields/src/Field/FieldLayoutField.php
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
* Fix missing quoteName in FieldLayoutField * remove empty space * Update administrator/components/com_fields/src/Field/FieldLayoutField.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Comment #43829 (review) .
Summary of Changes
Add missing $db->quoteName in FieldLayoutField
Testing Instructions
Create override
com_fields->fieldsRename the layout file e. g.
test.phpContent->Fields->New->Tab: Options-> and scroll to bottomyou should see your new layout override in the Layout Dropdown
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Nothing should be changed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed