Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix encoding for a few popup links #43874

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Aug 2, 2024

Pull Request for Issue #43013 .

Summary of Changes

Fix encoding for a popup links, for Finder and Redirect plugins.

Testing Instructions

Please follow #43013

Or add language overide:

COM_REDIRECT_EDIT_PLUGIN_SETTINGS="Тест"
COM_FINDER_EDIT_PLUGIN_SETTINGS="Тест"

Disable plugins Content - Finder, and System - Redirect.
Visit the Finder index and Redirects overview pages, and click on the link in the message.

Actual result BEFORE applying this Pull Request

Popup with broken heading

Expected result AFTER applying this Pull Request

Popup with text Тест

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik linked an issue Aug 2, 2024 that may be closed by this pull request
@Fedik Fedik added the bug label Aug 2, 2024
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 8692982


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43874.

1 similar comment
@fgsw
Copy link

fgsw commented Aug 3, 2024

I have tested this item ✅ successfully on 8692982


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43874.

@Hackwar Hackwar added RTC This Pull Request is Ready To Commit and removed bug PR-5.1-dev labels Aug 3, 2024
@bembelimen bembelimen merged commit e84b2bb into joomla:5.1-dev Aug 10, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 10, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.3 milestone Aug 10, 2024
@Fedik Fedik deleted the fix-encoding-plg-finder-redirect branch August 10, 2024 09:41
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.1] Problem with encoding in pop-up
6 participants