Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] svg sanitize update #43945

Merged
merged 8 commits into from
Sep 11, 2024
Merged

[5.2] svg sanitize update #43945

merged 8 commits into from
Sep 11, 2024

Conversation

brianteeman
Copy link
Contributor

I dont know why it didnt get updated but we should be using the latest version

summary of changes

  • 0.19.0 Preserve libxml errors after failed parsing
  • 0.18.0 Allow the enabling of loading large files
  • 0.17.0 Feature/8.3 support
  • 0.16.0 PHP 5.6 compatibility

I dont know why it didnt get updated but we should be using the latest version

summary of changes

- 0.19.0 Preserve libxml errors after failed parsing
- 0.18.0 Allow the enabling of loading large files
- 0.17.0 Feature/8.3 support
- 0.16.0 PHP 5.6 compatibility

Signed-off-by: BrianTeeman <brian@teeman.net>
@heelc29
Copy link
Contributor

heelc29 commented Aug 18, 2024

I dont know why it didnt get updated

Perhaps... https://getcomposer.org/doc/articles/versions.md#caret-version-range-
For pre-1.0 versions it also acts with safety in mind and treats ^0.3 as >=0.3.0 <0.4.0 and ^0.0.3 as >=0.0.3 <0.0.4.

@brianteeman
Copy link
Contributor Author

@heelc29 thanks - i didnt know that but it explains a lot

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev September 2, 2024 06:40
@HLeithner
Copy link
Member

Rebased it for 5.2, we will not have a 5.1 release any more, not sure if it's not too late for 5.2

@brianteeman
Copy link
Contributor Author

Thanks

@HLeithner HLeithner changed the title svg sanitize update [5.2] svg sanitize update Sep 2, 2024
@brianteeman
Copy link
Contributor Author

merge conflict fixed

Signed-off-by: BrianTeeman <brian@teeman.net>
This reverts commit d95de2666abef4948e3efdb08923dbf4f036f656.
@Hackwar Hackwar added RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Sep 11, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 11, 2024

I took the liberty to updating it to the latest version and fixing the broken composer.lock. When the tests pass, I'll merge this. Reviewing the changes between 0.15.4 and 0.20.0 this is all backwards compatible.

@brianteeman
Copy link
Contributor Author

Thanks

@Hackwar Hackwar merged commit de771e6 into joomla:5.2-dev Sep 11, 2024
3 checks passed
@Hackwar
Copy link
Member

Hackwar commented Sep 11, 2024

Thank you for your contribution @brianteeman

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 11, 2024
@brianteeman brianteeman deleted the svg-san branch September 11, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants