Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided Tours] Fix dropdown mouse accessibility on fancy selects #43960

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Aug 22, 2024

Summary of Changes

When a tour step targets a fancy select box (like the category or the tags field), the dropdown, although accessible with the keyboard, is not accessible with the mouse. Therefore, it is impossible to select a category or a tag via the mouse.

This PR fixes the issue by allowing a target and all inner elements to be available over the tour overlay.

Testing Instructions

Start the 'Create an article' tour. Go all the way to the selection of a category.
Then try and select tags.
Go through a couple tours to ensure there is no side-effect and that all tours can be run properly.

Note: the z-index of the overlay is 9997, the z-index of the step popups is 9999.
Therefore I chose a z-index of 9998 for the targets.
A good tour to test z-index values is the welcome tour. In the 'notifications panel' step, step and target can start to overlap on a smaller size window.

Actual result BEFORE applying this Pull Request

The dropdown cannot be clicked.

image

Expected result AFTER applying this Pull Request

The dropdown can be clicked.

image

In the welcome tour:

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Aug 22, 2024
@fgsw
Copy link

fgsw commented Aug 22, 2024

I have tested this item ✅ successfully on bb2a154

Test: All guided tours (macbook air, 13-inch, 2019).

Comment: In "Welcome tour > Notifications panel", step and target overlap on a smaller size window ("iphone se" on firefox responsive design mode). Why is the tour step not on top of the notifications panel?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43960.

@obuisard
Copy link
Contributor Author

obuisard commented Aug 22, 2024

Thank you for testing this PR!

Comment: In "Welcome tour > Notifications panel", step and target overlap on a smaller size window ("iphone se" on firefox responsive design mode). Why is the tour step not on top of the notifications panel?

The tours are not supported on screens smaller than 526 pixels (whenever the admin menu turns into 'mobile' mode).
That said, this is what I see when emulating IPhone SE in Firefox:

image

@coolcat-creations
Copy link
Contributor

I have tested this item ✅ successfully on bb2a154

Thank you, works now as expected :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43960.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43960.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@Hackwar Hackwar enabled auto-merge (squash) August 29, 2024 10:37
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 29, 2024
@Hackwar
Copy link
Member

Hackwar commented Aug 29, 2024

Thank you for your contribution @obuisard!

@Hackwar Hackwar merged commit 8a780c3 into joomla:5.2-dev Aug 29, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2024
@obuisard obuisard deleted the guided-tours-dropdowns branch October 29, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants