[5.3] Removing LegacyPropertyManagementTrait::setProperties() usage in Core #44008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
Language Change
|
Upmerge for 5.3 missing first? |
joomla-cms-bot
removed
Language Change
|
Shouldn't the use LegacyPropertyManagementTrait; be removed in the files? |
|
No, we can't remove those traits, because it would be a b/c break. I'm looking forward to removing the trait from everything in 6.0, but right now we are stuck with it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The LegacyPropertyManagementTrait is deprecated and we are still using setProperties in some areas. This PR removes the usage of that method from all occurences in our core.
Testing Instructions
Test registering a user and logging in and view a category view in the frontend. That should trigger all the code. There should be no difference between before and after applying this PR.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed