Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Fix event target in menu.js #44019

Merged
merged 6 commits into from
Sep 23, 2024
Merged

[4.4] Fix event target in menu.js #44019

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1dc9365
fix event target in menu.js
SniperSister Sep 4, 2024
b758a2a
Merge branch '4.4-dev' into fix/4.4-menujs
QuyTon Sep 19, 2024
6c9968b
Merge branch '4.4-dev' into fix/4.4-menujs
QuyTon Sep 20, 2024
196c3db
Merge branch '4.4-dev' into fix/4.4-menujs
QuyTon Sep 23, 2024
cce3dc7
Merge branch '4.4-dev' into fix/4.4-menujs
MacJoom Sep 23, 2024
b2dfa32
Merge branch '4.4-dev' into fix/4.4-menujs
MacJoom Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions build/media_source/mod_menu/js/menu.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,32 +44,32 @@
spanEl.addEventListener('mouseout', topLevelMouseOut(topLevelEl, settings));
}

topLevelEl.addEventListener('mouseover', ({ target }) => {
const ulChild = target.querySelector('ul');
topLevelEl.addEventListener('mouseover', ({ currentTarget }) => {
const ulChild = currentTarget.querySelector('ul');
if (ulChild) {
ulChild.setAttribute('aria-hidden', 'false');
ulChild.classList.add(settings.menuHoverClass);
}
});

topLevelEl.addEventListener('mouseout', ({ target }) => {
const ulChild = target.querySelector('ul');
topLevelEl.addEventListener('mouseout', ({ currentTarget }) => {
const ulChild = currentTarget.querySelector('ul');
if (ulChild) {
ulChild.setAttribute('aria-hidden', 'true');
ulChild.classList.remove(settings.menuHoverClass);
}
});

topLevelEl.addEventListener('focus', ({ target }) => {
const ulChild = target.querySelector('ul');
topLevelEl.addEventListener('focus', ({ currentTarget }) => {
const ulChild = currentTarget.querySelector('ul');
if (ulChild) {
ulChild.setAttribute('aria-hidden', 'true');
ulChild.classList.add(settings.menuHoverClass);
}
});

topLevelEl.addEventListener('blur', ({ target }) => {
const ulChild = target.querySelector('ul');
topLevelEl.addEventListener('blur', ({ currentTarget }) => {
const ulChild = currentTarget.querySelector('ul');
if (ulChild) {
ulChild.setAttribute('aria-hidden', 'false');
ulChild.classList.remove(settings.menuHoverClass);
Expand Down