-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] UPD composer files, phpseclib/bcmath_compat 2.0.3 #44036
Conversation
What did I do wrong here that the build test "continuous-integration/dron/pr with phpcs failed? |
@tkuschel If you check the changes in the |
Thank you for the detailed description, I have corrected this. |
It would have been better if you did what @richard67 said and ONLY updated bcmath with this PR. Other changes such as phpcs and changing the sprintf should be in their own pull requests. |
That's a good point. I will pick this apart. I didn't imagine that the |
@tkuschel You haven't reverted yet the unrelated changes of other dependencies. |
Had no time, now it looks good. I had dependencies with other local branches. |
Thank you for your contribution @tkuschel! |
Pull Request for Issue #44028 .
Updated composer files, b/c of fixed phpseclib/bcmath_compat#6
Summary of Changes
phpseclib/bcmath_compat from 2.0.2 to 2.0.3
The following 3 packages have also been updated as a side effect as expected:maximebf/debugbar v1.22.3 to v1.22.4
friendsofphp/php-cs-fixer v3.59.3 to v3.64.0
phpstan/phpstan 1.12.0 to 1.12.2
Actual result BEFORE applying this Pull Request
bcmath_compat:
The exception ArgumentCountError gives wrong given parameter length. see phpseclib/bcmath_compat#6
for more details.
Expected result AFTER applying this Pull Request
Fixed
Link to documentations