Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Fix workflow transition task name in featured articles layout #44053

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

SniperSister
Copy link
Contributor

@SniperSister SniperSister commented Sep 10, 2024

Summary of Changes

The workflow transition form in the featured articles view is using the wrong task name, therefore transitions are performed.

Testing Instructions

Configure a site with workflows, perform a transition for an article in the "feature articles" list view in the backend using the button in the column.

Actual result BEFORE applying this Pull Request

Transition not exectued

Expected result AFTER applying this Pull Request

Transition executed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

obvious fix. another example of how few people can be using workflows.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 0ea631e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44053.

@chmst
Copy link
Contributor

chmst commented Sep 10, 2024

I have tested this item ✅ successfully on 0ea631e

Code review - obvious.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44053.

@chmst chmst removed the PR-4.4-dev label Sep 10, 2024
@chmst
Copy link
Contributor

chmst commented Sep 10, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44053.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 10, 2024
@laoneo laoneo added this to the Joomla! 4.4.9! milestone Sep 10, 2024
@laoneo laoneo merged commit edef0d1 into joomla:4.4-dev Sep 10, 2024
4 checks passed
@laoneo
Copy link
Member

laoneo commented Sep 10, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 10, 2024
@richard67 richard67 added the bug label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants