[4.4] Fix next exec calculation for task scheduler #44061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandewt
reviewed
Sep 12, 2024
administrator/components/com_scheduler/src/Helper/ExecRuleHelper.php
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on 52f7cb7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44061. |
1 similar comment
|
I have tested this item ✅ successfully on 52f7cb7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44061. |
|
Not sure to mark RTC per comment. |
|
@Quy I would set RTC because it is a good step in the right direction and we only have a few days before the last 4.4.x Version before securtiy only fixes will be released. It would be a shame to have it so broken as it is now. I am going to make a 2nd PR and will work on the other issues in the comment. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44061. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42459 partly .
Summary of Changes
The calculation of the next execution is not working as expected. This fix is for the intervals:
I haven't looked into the cron-execution but will do in the furture (seems to me working right).
Testing Instructions
Create a task (e.g. Sleep) and chose Interval Days and set "Interval in Days" to 1 and the "Execution Time (UTC)" to 11:11 and save it.
Actual result BEFORE applying this Pull Request
You will see that the day is the next day but the time is the current time.
Expected result AFTER applying this Pull Request
The day is the next day and the time is 11:11
Apply the patch and try again, now it should be as expected. Play around with the other options and settings.
For the calculation of the next execution I have used the current time, then I am adding the interval and finally set time and day if needed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed