Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Calendar Strings #44099

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[5.3] Calendar Strings #44099

merged 2 commits into from
Sep 18, 2024

Conversation

brianteeman
Copy link
Contributor

Remove the special check for language strings introduced in 4.0. No longer needed and strings are used elsewhere without this extra check

code review

Remove the special check for language strings introduced in 4.0. No longer needed and strings are used elsewhere without this extra check

Signed-off-by: BrianTeeman <brian@teeman.net>
@richard67
Copy link
Member

I have tested this item ✅ successfully on ca2afd1

The strings were introduced with PR #34870 , so I agree that there was enough time to adjust translations.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44099.

@Quy
Copy link
Contributor

Quy commented Sep 18, 2024

I have tested this item ✅ successfully on ca2afd1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44099.

@Quy
Copy link
Contributor

Quy commented Sep 18, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44099.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@laoneo laoneo merged commit cb1d4a0 into joomla:5.3-dev Sep 18, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@laoneo
Copy link
Member

laoneo commented Sep 18, 2024

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Sep 18, 2024
@brianteeman brianteeman deleted the ampm branch September 18, 2024 06:49
@brianteeman
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants