[5.2] [Guided Tours] Fix content and footer padding

[obuisard]

Pull Request for Issue #44096.

Summary of Changes

When footer buttons are missing, the step content has no bottom padding.

Testing Instructions

There is no core tour that can show this behavior.

Create a new tour (with relative URL: administrator/index.php, Component selector: 'Home dashboard').

Create the following steps for the tour:

Step 1:
Position: Bottom
Target: .quickicon a[href*=com_config]
Type: Interactive
Interactive type: Form submit

Step 2:
Position: Bottom
Target: #toolbar-save
Type: Interactive
Interactive type: Form submit

Step 3:
Position: Center
Type: Next

It does not matter what you enter in titles and descriptions.

Run the tour.

Run other tours and make sure bottom padding is correct in the other tour(s) you run.

Actual result BEFORE applying this Pull Request

No padding at the bottom of the popup in step 3.

Expected result AFTER applying this Pull Request

Padding at the bottom of the popup in step 3.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Kostelano]

I have tested this item ✅ successfully on a38c01b

It works, it's been tested.

The test instructions are not complete, after step 2 you need to create another step - informational, since step 2 of the test instructions (if it is the final one) will have a Close button, and we need to get a step without buttons.

In addition, the PR can be tested on an existing tour - a tour for creating STEPS (specifically step 3).

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44104.}

[richard67]

@obuisard node build/build.js --prepare fails in Drone. It seems there is something wrong with the CSS, but I don't see any mistake.
I will try if a branch update helps.

[obuisard]

I have tested this item ✅ successfully on a38c01bIt works, it's been tested.

The test instructions are not complete, after step 2 you need to create another step - informational, since step 2 of the test instructions (if it is the final one) will have a Close button, and we need to get a step without buttons.

Thanks for the correction, you are right, it needs an extra step. I had one in my test tour.

[obuisard]

@obuisard node build/build.js --prepare fails in Drone. It seems there is something wrong with the CSS, but I don't see any mistake. I will try if a branch update helps.

Got it, it does not like the order of the properties...

[richard67]

@Kostelano Could you briefly test again if it still works? I don't expect any issues but I'd like to be safe. Thanks in advance.

[Kostelano]

I have tested this item ✅ successfully on bcc1df9

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44104.}

[obuisard]

I followed the requested change in Drone, but apparently it is not 'smart' enough to tell us the whole story. I had to change the order again. I apologize (I am not sure where to find information about what the order should be, as there is no standard for CSS property order).

[tecpromotion]

I have tested this item ✅ successfully on 0abeffd

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44104.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44104.}

[tecpromotion]

Step 3 in "How to add steps to a guided tour?" now with padding.
/administrator/index.php?option=com_guidedtours&view=steps&tour_id=12

[Hackwar]

Thanks for your contribution @obuisard!