Article module fix read more title

[RickR2H]

Pull Request for Issue #44135

Summary of Changes

Fix the read more title functionality.

Testing Instructions

• Toggle the function Read More with Title on and off and see if the title is shown or hidden
• Change the Read More Limit (characters) to 15 to see if the title is shortened,

Actual result BEFORE applying this Pull Request

Toggle Read More with Title not working

Expected result AFTER applying this Pull Request

Toggle Read More with Title is working and truncation of title is working

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

I have tested this item 🔴 unsuccessfully on b996b09

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[brianteeman]

chrome_2AW7e91m2w.mp4

[RickR2H]

@brianteeman This option only reflects the settings in the module. Article parameters are not respected. This could be a feature we can add in the future. @drmenzelit What do you suggest?

[brianteeman]

@brianteeman This option only reflects the settings in the module. Article parameters are not respected.

Yes that is how it should work but it does not.

My point is that the setting in the content component are preventing the setting in the module from working.

check it out yourself.

1. set the content component options to hide readmore title
2. set the module to show readmore title

expected behaviour - module shows the readmore title
actual behaviour - module does not show the readmore title

[brianteeman]

joomla-cms/modules/mod_articles/tmpl/default_items.php

Line 108 in cb1d4a0

<?php echo LayoutHelper::render('joomla.content.readmore', ['item' => $item, 'params' => $item->params, 'link' => $item->link]); ?>

This line is getting the params from the article - it should be getting the params from the module

[RickR2H]

@brianteeman please test again.

[brianteeman]

other than comments about the class names this works correctly

[JeroenMoolenschot]

Thanks Rick!

One small inconsistency

The module now shows > Read more ... Title.

While the component shows > Read more: Title

Without displaying the title it works both the same

[brianteeman]

Good spot
Without the title it should be using JGLOBAL_READ_MORE
With the title is should be using JGLOBAL_READ_MORE_TITLE

[RickR2H]

Thanks for the feedback! Hopefully fixed now.

[brianteeman]

I have tested this item ✅ successfully on e00e280

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[JeroenMoolenschot]

I have tested this item ✅ successfully on e00e280

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[RickR2H]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[brianteeman]

I think it would be better to do this the way that @rdeutz has done with #43457 - that way you can still use the layout etc

[brianteeman]

Removed my positive test as I think this is doing it the wrong way

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[RickR2H]

@brianteeman please test the new version.

[brianteeman]

I have tested this item ✅ successfully on a81d79c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[richard67]

@RickR2H I've allowed myself to fix the merge conflict which was caused by your other, merged PR #44132 in file "modules/mod_articles/tmpl/default_items.php". What remains is the unresolved conversation above.

[richard67]

Back to pending as the test by @JeroenMoolenschot has been invalidated by a later change which was not just a branch update. I will restore @brianteeman 's test result as that was just invalidated by a branch update (with a merge conflict resolved by me but that is not relevant for the test result). But the inresolved conversation should be resolved, and it needs a 2nd human test.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[brianteeman]

I have not tested this item.

Removing my test as the active makes no sense

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.}

[RickR2H]

@Quy could you please test again?

[Hackwar]

I merged this because the latest changes were removing the unrelated active status and the actual code in this PR was successfully tested before. Thank you @RickR2H for your contribution.