-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5][com_privacy] language file not loaded #44192
Conversation
I have tested this item ✅ successfully on 7bd6402 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192. |
I have tested this item ✅ successfully on 7bd6402 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192. |
@alikon Why for the 5.1-dev branch? There will not be any new 5.1 release. The PR should be made for the 5.2-dev branch. Could you rebase? |
didn't know |
|
I think it doesn’t need new test and RTC is still ok as the rebase from 5.1-dev to 5.2-dev was clean without any conflicts. |
Thanks @alikon ! |
Pull Request for Issue #44054
Summary of Changes
load lang file
Testing Instructions
Have a user confirm acceptance of the Privacy Policy on login (Enable the System - Privacy Consent plugin)
Go to the administrator Privacy / Consents page.
Actual result BEFORE applying this Pull Request
The Subject is a string key: PLG_SYSTEM_PRIVACYCONSENT_SUBJECT
Expected result AFTER applying this Pull Request
the Subject is a translated
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed