Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5][com_privacy] language file not loaded #44192

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 5, 2024

Pull Request for Issue #44054

Summary of Changes

load lang file

Testing Instructions

Have a user confirm acceptance of the Privacy Policy on login (Enable the System - Privacy Consent plugin)
Go to the administrator Privacy / Consents page.

Actual result BEFORE applying this Pull Request

The Subject is a string key: PLG_SYSTEM_PRIVACYCONSENT_SUBJECT

Expected result AFTER applying this Pull Request

the Subject is a translated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 7bd6402


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192.

@ceford
Copy link
Contributor

ceford commented Oct 5, 2024

I have tested this item ✅ successfully on 7bd6402

Good - I see the the Subject change from a key to the translated string.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192.

@alikon
Copy link
Contributor Author

alikon commented Oct 5, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 5, 2024
@richard67
Copy link
Member

@alikon Why for the 5.1-dev branch? There will not be any new 5.1 release. The PR should be made for the 5.2-dev branch. Could you rebase?

@alikon alikon changed the base branch from 5.1-dev to 5.2-dev October 5, 2024 18:46
@alikon
Copy link
Contributor Author

alikon commented Oct 5, 2024

didn't know

@richard67
Copy link
Member

@richard67
Copy link
Member

I think it doesn’t need new test and RTC is still ok as the rebase from 5.1-dev to 5.2-dev was clean without any conflicts.

@richard67 richard67 added the bug label Oct 7, 2024
@pe7er pe7er enabled auto-merge (squash) October 16, 2024 16:09
@pe7er pe7er self-assigned this Oct 16, 2024
@pe7er pe7er merged commit 59b1341 into joomla:5.2-dev Oct 16, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 16, 2024
@alikon alikon deleted the patch-21 branch October 17, 2024 06:21
@rdeutz rdeutz added this to the Joomla! 5.2.0 milestone Oct 18, 2024
@pe7er
Copy link
Contributor

pe7er commented Oct 18, 2024

Thanks @alikon !

@rdeutz rdeutz modified the milestones: Joomla! 5.2.0, Joomla! 5.2.1 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants