Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] use _JEXEC for restricted access #44193

Merged
merged 5 commits into from
Oct 20, 2024

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Oct 6, 2024

Summary of Changes

replace check of constant from JPATH_BASE to _JEXEC for restricted access
like other files eg.

// phpcs:disable PSR1.Files.SideEffects
\defined('_JEXEC') or die;
// phpcs:enable PSR1.Files.SideEffects

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

JPATH_BASE is used for check of restricted access

Expected result AFTER applying this Pull Request

JPATH_BASE is not used for check of restricted access

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Oct 6, 2024

I have tested this item ✅ successfully on b8a737b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on b8a737b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 6, 2024
@heelc29 heelc29 changed the base branch from 4.4-dev to 5.2-dev October 16, 2024 17:38
@heelc29 heelc29 changed the title [4.4] use _JEXEC for restricted access [5.2] use _JEXEC for restricted access Oct 16, 2024
@heelc29
Copy link
Contributor Author

heelc29 commented Oct 16, 2024

Rebased to 5.2-dev

@Quy Quy removed the PR-4.4-dev label Oct 16, 2024
@pe7er pe7er self-assigned this Oct 18, 2024
@laoneo laoneo modified the milestone: Joomla! 5.2.1 Oct 18, 2024
@pe7er pe7er enabled auto-merge (squash) October 20, 2024 11:56
@pe7er pe7er merged commit 13c6a90 into joomla:5.2-dev Oct 20, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 20, 2024
@pe7er
Copy link
Contributor

pe7er commented Oct 20, 2024

Thanks @heelc29 !

@pe7er pe7er added this to the Joomla! 5.2.1 milestone Oct 20, 2024
@heelc29 heelc29 deleted the 4.4/jexec-usernamerule branch October 26, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants