Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] fix for undefined property: $module #44280

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 16, 2024

Pull Request for Issue #44260.

Summary of Changes

options is already getted for module too

Testing Instructions

Edit a plugin.
Click Save button.
See PHP error log.

Actual result BEFORE applying this Pull Request

PHP Warning: Undefined property: Joomla\CMS\Table\Extension::$module in \plugins\actionlog\joomla\src\Extension\Joomla.php on line 536

Expected result AFTER applying this Pull Request

no more warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review October 16, 2024 15:14
@fgsw
Copy link

fgsw commented Oct 17, 2024

I have tested this item ✅ successfully on f694100


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44280.

@Quy
Copy link
Contributor

Quy commented Oct 25, 2024

This will undo PR #22545 for issue #22532.

@alikon
Copy link
Contributor Author

alikon commented Oct 25, 2024

now #22545 is in place too

@Quy
Copy link
Contributor

Quy commented Oct 27, 2024

I have tested this item ✅ successfully on 2aba8ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44280.

1 similar comment
@fgsw
Copy link

fgsw commented Oct 28, 2024

I have tested this item ✅ successfully on 2aba8ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44280.

@alikon
Copy link
Contributor Author

alikon commented Oct 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44280.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 28, 2024
@Hackwar Hackwar enabled auto-merge (squash) November 1, 2024 22:10
@Hackwar Hackwar added this to the Joomla! 5.2.1 milestone Nov 1, 2024
@Hackwar
Copy link
Member

Hackwar commented Nov 1, 2024

Thank you for your contribution!

@Hackwar Hackwar merged commit 94bd619 into joomla:5.2-dev Nov 1, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 1, 2024
@alikon alikon deleted the patch-22 branch November 2, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants