[5.3] Remove autostart temp code #44287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla#43031 introduced some code > At this point, the autostart is not present as an option to the user. Once we have the full functionality (we will make auto-start as an option to the tour in the form), we can remove that additional test. The full functionality is now available and this code can be removed. Testing is simple just try and duplicate an existing tour. It should be successfuly duplicated both with and without this PR Signed-off-by: BrianTeeman <brian@teeman.net>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43031 introduced some code
The full functionality is now available and this code can be removed.
Testing is simple just try and duplicate an existing tour. It should be successfully duplicated both with and without this PR
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed