[5.3] Add missing MVCFactoryInterface into model constructors #44295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but I would make this for 5.3 and not for 5.2. Would give us some more time to test and be sure we don't have unexpected side effects. |
|
@rdeutz Great, rebased to 5.3-dev |
Denitz
changed the title
|
Can you fix the conflict here? |
…ctory-in-models # Conflicts: # administrator/components/com_content/src/Model/FeaturedModel.php
|
@laoneo Resolved. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
There are models which don't unitilize the
MVCFactoryInterface $factoryconstructor argument for calling parent's constructor.This results to useless extra calls to
Factory::getApplication()->bootComponent()inBaseDatabaseModel::__construct.Testing Instructions
Apply patch, ensure no errors on actions with patched models.
Actual result BEFORE applying this Pull Request
Model constructors are missing
MVCFactoryInterface $factoryargument.Expected result AFTER applying this Pull Request
All good.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed