Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Media manager fix default adapter handling #44313

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Oct 19, 2024

Pull Request for Issue #44277 .

Summary of Changes

Media manager produces an error when "Path to Files Folder" field contain folder that not in the plugin "FileSystem - Local".
I have fixed fallback to first available adapter.

Testing Instructions

Edit Media manager global options, set "Path to Files Folder" to some random existing folder.
Make sure this folder does not selected in plugin "FileSystem - Local".
Enable Drag&Drop upload for TinyMCE.
Open Article editing.

Actual result BEFORE applying this Pull Request

An error page

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@spike277
Copy link

Solution only works in backend. Frontend-Editing have still the Error

@Fedik
Copy link
Member Author

Fedik commented Oct 27, 2024

Frontend-Editing have still the Error

Cannot be, the code is the same for both, for administrator and for site.

@bcordis
Copy link
Contributor

bcordis commented Oct 31, 2024

I have tested this item ✅ successfully on b80e9eb

Tested Successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44313.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on b80e9eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44313.

@Quy
Copy link
Contributor

Quy commented Nov 1, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44313.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 1, 2024
@Octopus2
Copy link

I would be very happy if this bug fix could be integrated into Joomla 5.2.2. The problem has hit my mirror installation, so that no more posts could be edited at any point. Without the fix, my actively used version will have to remain on Joomla 4, which is not an ideal solution for me. Is there possibly another way to support the process?

@spike277
Copy link

Yes, me to. Problem in Frontend still in Joomla 5.2.1. Not good :( Hope also to fix it.

@rdeutz rdeutz enabled auto-merge (squash) November 13, 2024 17:58
@rdeutz rdeutz merged commit e6173bd into joomla:5.2-dev Nov 13, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 13, 2024
@Fedik Fedik deleted the fix-44277 branch November 13, 2024 19:28
@Quy Quy added this to the Joomla! 5.2.2 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants