[5.2] Articles Module: Remove unused css + modified container query #44327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
I have tested this item ✅ successfully on 11e8e25 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327. |
drmenzelit
changed the title
|
I have tested this item 🔴 unsuccessfully on f298190 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327. |
1 similar comment
|
I have tested this item 🔴 unsuccessfully on f298190 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327. |
|
@WM-Loose Can you delete 2 of your 3 identical comments above? |
|
I have tested this item ✅ successfully on f298190 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327. |
|
It works now. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327. |
|
I have tested this item ✅ successfully on f298190 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44327. |
|
Thanks @drmenzelit ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional change to fix #44369
Modified the container query to address the div/section that is direct parent of the module.
Summary of Changes
We removed some code from the Articles Module, but forgot to remove the related css. This PR remove some lines in the css file.
Testing Instructions
Create an articles module.
Checkout the PR and run
npm run build:csson your development environmentExpected result AFTER applying this Pull Request
No differences in the styling of the module
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed