Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix public folder path when trailing slash is added #44340

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

bembelimen
Copy link
Contributor

Summary of Changes

Remove any trailing slashes for public folder path constant

Testing Instructions

Actual result BEFORE applying this Pull Request

  • error: Site not found

Expected result AFTER applying this Pull Request

  • ajax call works
  • no trailing slash in the defines.php in your public folder

@dgrammatiko probably you could check if you agree

thanks @HLeithner for helping debugging.

@dgrammatiko
Copy link
Contributor

@bembelimen probably worth mentioning that this happens on windows based OSes

@bembelimen
Copy link
Contributor Author

I have the problem on a linux server :)

@HLeithner
Copy link
Member

I have tested this item ✅ successfully on 54beab8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44340.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 54beab8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44340.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44340.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 29, 2024
@rdeutz rdeutz merged commit 66344af into joomla:5.2-dev Oct 29, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 29, 2024
@rdeutz rdeutz added this to the Joomla! 5.2.1 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants