Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided Tours] Fix blank screen after a session time out on the steps page #44375

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Oct 29, 2024

Summary of Changes

This PR adds the missing getRedirectToListAppend function in the Step Controller that adds the missing tour_id query in the steps URL after returning from step edition.

Testing Instructions

Go to the Global Configuration, 'System' tab.
Set the session lifetime to 2mn.

Go to System -> Manage -> Guided Tours and go to the list of steps for a tour.
The URL in the browser address bar will be something like:
administrator/index.php?option=com_guidedtours&view=steps&tour_id=X

Edit a step. Cancel the edition (Select 'close').
The URL is now:
administrator/index.php?option=com_guidedtours&view=steps

Let the session run out.
Log back in.

Actual result BEFORE applying this Pull Request

When the user logs back in, the page is blank.

Expected result AFTER applying this Pull Request

When the user logs back in, the list of steps is available.
The URL when returning from step edition is:
administrator/index.php?option=com_guidedtours&view=steps&tour_id=X
(the tour_id query is always present).

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Oct 30, 2024

I have tested this item ✅ successfully on 9e0522c

Comment: Like to test your Pull Requests; easy understandable Instructions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44375.

@richard67 richard67 added the bug label Oct 30, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9e0522c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44375.

@Quy
Copy link
Contributor

Quy commented Oct 31, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44375.

@Quy Quy removed the bug label Oct 31, 2024
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 31, 2024
@Hackwar Hackwar enabled auto-merge (squash) October 31, 2024 10:54
@Hackwar Hackwar merged commit c9057e1 into joomla:5.2-dev Oct 31, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 31, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.1 milestone Oct 31, 2024
@Hackwar
Copy link
Member

Hackwar commented Oct 31, 2024

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants