[Guided Tours] Fix blank screen after a session time out on the steps page #44375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds the missing
getRedirectToListAppend
function in the Step Controller that adds the missing tour_id query in the steps URL after returning from step edition.Testing Instructions
Go to the Global Configuration, 'System' tab.
Set the session lifetime to 2mn.
Go to System -> Manage -> Guided Tours and go to the list of steps for a tour.
The URL in the browser address bar will be something like:
administrator/index.php?option=com_guidedtours&view=steps&tour_id=X
Edit a step. Cancel the edition (Select 'close').
The URL is now:
administrator/index.php?option=com_guidedtours&view=steps
Let the session run out.
Log back in.
Actual result BEFORE applying this Pull Request
When the user logs back in, the page is blank.
Expected result AFTER applying this Pull Request
When the user logs back in, the list of steps is available.
The URL when returning from step edition is:
administrator/index.php?option=com_guidedtours&view=steps&tour_id=X
(the tour_id query is always present).
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed