Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL in email broken with Mail Template Layout #44378

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

leeroy1821
Copy link
Contributor

Pull Request for Issue #44377 .

Summary of Changes

Move convertRelativeToAbsoluteUrls after replaceTags

Testing Instructions

Mail template com_users.password_reset, HTML Body:

<p>Hello,</p>
<p>
	A request has been made to reset your {SITENAME} account password. To reset your password, you will need to submit this verification code to verify that the request was legitimate.
</p>
<p>
    The verification code is {TOKEN}
</p>
<p>
	Click <a href="{LINK_HTML}">here</a> and proceed with resetting your password.    
</p>
<p>
    Thank you.
</p>

Go frontent.

Forgot your password?

Check email Joomla sent you.

Actual result BEFORE applying this Pull Request

URL in email is broken: https://www.mysite.com/https://www.mysite.com/component/users/reset.html?layout=confirm&amp;token=blablabla&amp;Itemid=123

The https://www.mysite.com is dobled in email.

Expected result AFTER applying this Pull Request

URL in email is correct: https://www.mysite.com/component/users/reset.html?layout=confirm&amp;token=blablabla&amp;Itemid=123

No dobled https://www.mysite.com in email.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Oct 31, 2024

I have tested this item ✅ successfully on 32525d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 32525d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378.

@alikon
Copy link
Contributor

alikon commented Oct 31, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 31, 2024
@alikon alikon added bug RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Oct 31, 2024
@HLeithner HLeithner merged commit 69e2e1f into joomla:5.2-dev Oct 31, 2024
4 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 31, 2024
@Quy Quy added this to the Joomla! 5.2.1 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants