Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate methods for batch remove tag handling #44383

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

beni71
Copy link
Contributor

@beni71 beni71 commented Oct 31, 2024

This is a prework for PR #40613 of feature request #23185 . It adds just deprecation messages onto two methods.

Testing Instructions

There is nothing to test because no logic change.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Oct 31, 2024
@softforge
Copy link
Contributor

@beni71 It just needs the deprecation comments that the method is deprecated and removed in 7, not all the file changes.
If you can do that we will merge in the 6.0 branch

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester labels Oct 31, 2024
@beni71 beni71 changed the title Added possibility to batch remove a tag Deprecate methods for batch remove a tag handling Oct 31, 2024
@beni71 beni71 changed the title Deprecate methods for batch remove a tag handling Deprecate methods for batch remove tag handling Oct 31, 2024
@Bodge-IT
Copy link

Bodge-IT commented Nov 8, 2024

@Hackwar can this PR be RTC'd and merged? We can then take care of #40613.

@Bodge-IT Bodge-IT merged commit 7ff41c4 into joomla:5.3-dev Nov 13, 2024
3 checks passed
@Bodge-IT
Copy link

Thanks @beni71. Deprecate comments ready for #40613 also merged.

@Quy Quy added this to the Joomla! 5.3.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants