Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5] fix for Error with trashing items when items are checked out #44392

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Nov 1, 2024

Pull Request for Issue #44364 .

Summary of Changes

just prune items that you can't change

Testing Instructions

see #44364 for details

Actual result BEFORE applying this Pull Request

No item is trashed but the message says "n-1 items are trashed" plus "checked-out" message

Expected result AFTER applying this Pull Request

All items except the checked-out item are trashed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review November 1, 2024 12:54
@alikon alikon changed the title [5] just Prune items that you can't change [5] fix for Error with trashing items when items are checked out Nov 1, 2024
@alikon alikon added the bug label Nov 1, 2024
@chmst
Copy link
Contributor

chmst commented Nov 1, 2024

I have tested this item ✅ successfully on 69a7537


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44392.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Nov 1, 2024

I have tested this item ✅ successfully on 69a7537


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44392.

@Quy
Copy link
Contributor

Quy commented Nov 1, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44392.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 1, 2024
@Hackwar Hackwar merged commit c0539b1 into joomla:5.2-dev Nov 1, 2024
4 checks passed
@Hackwar Hackwar added this to the Joomla! 5.2.1 milestone Nov 1, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 1, 2024
@Hackwar
Copy link
Member

Hackwar commented Nov 1, 2024

Thank you for this contribution!

@alikon alikon deleted the patch-24 branch November 1, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants