Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] fix preprocess rule if contains alias (pgsql) #44459

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Nov 14, 2024

Summary of Changes

fix database exception in preprocessrule (new in #43992)

Only with PostgreSQL database

Testing Instructions

  • create an contact
  • create an menu item for the new contact
  • open https://example.com/index.php?option=com_contact&view=contact&id={contact.id}:{contact.alias}

Actual result BEFORE applying this Pull Request

PDOException: SQLSTATE[22P02]: Invalid text representation: 7 ERROR:  invalid input syntax for type integer: "xx:xxx"
CONTEXT:  unnamed portal parameter $1 = '...'

redirect to home menu item (see also systemtests in upmerge pr #44456)

Expected result AFTER applying this Pull Request

redirect to contact menu item

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I have tested this item ✅ successfully on 998dfad

Hint for other testers: The error mentioned in the actual result of the testing instructions is not shown anywhere on the site. It can be found in the database server log, e.g. on Ubuntu with PostgreSQL 14 in file "/var/log/postgresql/postgresql-14-main.log".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44459.

@richard67
Copy link
Member

@alikon Could you test this PR here with PostgreSQL?

@bembelimen bembelimen enabled auto-merge November 16, 2024 18:54
@HLeithner HLeithner disabled auto-merge November 16, 2024 19:01
@HLeithner HLeithner enabled auto-merge (squash) November 16, 2024 21:50
@HLeithner HLeithner merged commit b333dc4 into joomla:5.3-dev Nov 16, 2024
3 checks passed
@Quy Quy modified the milestones: Joomla! 5.4.0, Joomla! 5.3.0 Nov 16, 2024
@heelc29 heelc29 deleted the 5.3/fix-preprocessrule branch January 19, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants