-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Display the correct changelog when updating #44652
base: 5.2-dev
Are you sure you want to change the base?
Conversation
i'm unable to replicate the issue using the current 5.2-dev same as #44626 could not replicate the issue |
Did you check, that the URL in the extension table is not set? The problem is, that the code uses the changelog URL of the extension table instead of the updatesite. |
ahhh ok removing the changelog url from the extension table i'm able to replicate |
I have tested this item ✅ successfully on b9f5436 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44652. |
thanks! |
I have tested this item ✅ successfully on b9f5436 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44652. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44652. |
Pull Request for Issue #43505 .
Summary of Changes
When an extension provides a changelog URL in its update XML, a button is displayed to show the changelog, but the URL only loads the changelog from the current extension, not from the update site.
Testing Instructions
#__updates
look for the entry for your extension update. Edit the changelogurl column and insert a URL to achangelog.xml
in your sites root, for examplehttp://localhost/changelog.xml
changelog.xml
with the content below. (Adapt the content to the extension you've been using for this)Content for the changelog.xml
Actual result BEFORE applying this Pull Request
A modal opens and is empty.
Expected result AFTER applying this Pull Request
A modal opens and shows a few entries
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed