[6.0] Remove direct dependency on voku/portable-utf8 #44654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
reviewed
Dec 22, 2024
| @@ -4737,20 +4737,20 @@ | |||
| }, | |||
| { | |||
| "name": "symfony/polyfill-iconv", | |||
| "version": "v1.30.0", | |||
| "version": "v1.31.0", | |||
There was a problem hiding this comment.
It seems this PR does more than just removing the voku/portable-utf8 dependency, see. e.g. the update for symfony/polyfill-iconv here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes the direct dependency on voku/portable-utf8. That package is only used with wamania/phpstemmer and I think we only added this because of a version conflict during Joomla 4. At the same time, I created a PR for wamania/phpstemmer to switch their dependency from voku/portable-utf8 to joomla/string instead. If this change is accepted, we could drop that library entirely with Joomla 6.
Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed