Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Composer update enshrined/svg-sanitize to fix SVG uploads #44746

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Jan 18, 2025

Pull Request for Issue #38532 (part) .

See #38532 (comment) .

Summary of Changes

This pull request (PR) updates the composer dependency "enshrined/svg-sanitize" from 0.20.0 to the next version 0.21.0.

This fixes the upload of SVG files which contain a dominant-baseline attribute.

See darylldoyle/svg-sanitizer#112 and https://github.com/darylldoyle/svg-sanitizer/releases/tag/0.21.0 .

Testing Instructions

Set media options to allow svg files (allowed extensions), svg image files and image/svg+xml mimetype.

Go to media manager

Upload an SVG file which contains a dominant-baseline attribute.

You can download the SVG file from this issue darylldoyle/svg-sanitizer#111 here: svg-file .

Actual result BEFORE applying this Pull Request

Error "Unable to upload file".

Expected result AFTER applying this Pull Request

SVG file is uploaded and shows in media manager.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@MacJoom
Copy link
Contributor

MacJoom commented Jan 18, 2025

I have tested this item ✅ successfully on a040824

Used the prebuilt packages. Previously suspicous file works now (taken from within darylldoyle/svg-sanitizer#111)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44746.

@dautrich
Copy link

I have tested this item ✅ successfully on a040824


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44746.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44746.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2025
@Hackwar Hackwar enabled auto-merge (squash) January 18, 2025 20:00
@Hackwar Hackwar merged commit 088e878 into joomla:5.2-dev Jan 18, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 18, 2025
@richard67 richard67 deleted the 5.2-dev-composer-update-svg-sanitize branch January 18, 2025 20:26
@richard67 richard67 added this to the Joomla! 5.2.4 milestone Jan 18, 2025
@Hackwar
Copy link
Member

Hackwar commented Jan 18, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants