-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Re-add FeaturedModel for correct deprecation #45015
Open
chmst
wants to merge
7
commits into
joomla:6.0-dev
Choose a base branch
from
chmst:gsoc2021-featured-featuredmodel
base: 6.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPCS is failing. |
laoneo
reviewed
Feb 25, 2025
administrator/components/com_content/src/Model/FeaturedModel.php
Outdated
Show resolved
Hide resolved
richard67
reviewed
Feb 26, 2025
administrator/components/com_content/src/Model/FeaturedModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Feb 28, 2025
- New 5.x update SQL scripts - Deleted files and folder from PR joomla#43907 minus the file added back with PR joomla#45015
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Related to #43907
Summary of Changes
Re-add the class Administrator FeaturedModel
Testing Instructions
Using the featured articles in backend runs without errors or warnings.
If y developer wants to use the FeaturedModle in a a own module or component, the deprecated warning is visible.
Actual result BEFORE applying this Pull Request
Users may wonder where the file FeaturedModel.php in the daministrator component com_content has gone
Expected result AFTER applying this Pull Request
The file exits and has deprecated infromation
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed