[6.0] Disable compat plugin for system tests again #45414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can also be rebased to 5.4. |
Member
Author
@laoneo It was only enabled again in 6.0-dev. In 5.4-dev it should be disabled like it is disabled on 5.3-dev. |
Contributor
|
Thank you @richard67 for your ever-diligent work |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) disables again the b/c plugin during system tests in the 6.0-dev branch.
This has been done first in the 5.2-dev branch with PR #44997.
However, after PR #44240 was merged in the 6.0-dev branch, the system tests failed in the upmerge PR #45075 due to the change from PR #44997 , so we had to revert that temporarily.
Meanwhile the framework PR joomla-framework/filesystem#72 has been merged, a new release of the framework filesystem package has been made, that has been fetched into the CMS, then PR #45139 has been made, and finally all that has been merged up into 6.0-dev.
So now we can revert that temporary revert again and are back to how it should be.
This is that this PR here does.
Testing Instructions
Check that system tests succeeded in Drone for this PR here.
Actual result BEFORE applying this Pull Request
System tests succeed, but they run with the b/c plugin being switched on.
Expected result AFTER applying this Pull Request
System tests succeed with the b/c plugin being switched off.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed