[5.4] Move PHPstan deprecated database interface errors from baseline to main config

[richard67]

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adds new entries in the ignoreErrors section of the phpstan.neon file for deprecation errors of which we already know that they will be solved in J6 with the update of the database framework from 3 to 4, and removes the corresponding ignored errors from the phpstan-baseline.neon file, which are quite a lot.

These entries all were added to the phpstan-baseline.neon file with the update of the composer dependencies with my PR #45777 because the updated PHPstan version is more sensitive for such errors than the older version which we use in the 5.3-dev branch.

However, having them in the baseline file makes it hard to find them and remove them in 6.0-dev, and in 5.4-dev new PRs may require to add more entries in the baseline file.

So it is better to have general exclusions for these deprecations in the main configuration file phpstan.neon.

This is what this PR here does.

The new entries in the phpstan.neon file can be removed in 6.0-dev when that branch has gotten the framework update.

Testing Instructions

Code review and check CI:

• Check that this PR only removes entries from the phpstan-baseline.neon file and does not add new one.
• Check that PHPstan is successfull for this PR.

Actual result BEFORE applying this Pull Request

We have lots of exclusions in the phpstan-baseline.neon for calls to methods of deprecated interfaces Joomla\\Database\\Query\\PrepareableInterface and Joomla\\Database\\Query\\LimitableInterface.

Expected result AFTER applying this Pull Request

We no exclusions in the phpstan-baseline.neon for calls to methods of deprecated interfaces Joomla\\Database\\Query\\PrepareableInterface and Joomla\\Database\\Query\\LimitableInterface.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[muhme]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45814.}

[muhme]

Thank you @richard67 and @rdeutz.