Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protostar template doesn't work with component links in SEF #5085

Closed
wants to merge 1 commit into from

Conversation

waveywhite
Copy link
Contributor

Fix issue #5081 by making template script and css links absolute rather than relative.

Fix issue 5081 by making template script and css links absolute rather than relative.
@Bakual Bakual changed the title Update index.php Protostar template doesn't work with component links in SEF Nov 11, 2014
@Bakual
Copy link
Contributor

Bakual commented Nov 11, 2014

Copy from Issue:


In index.php for the protostar template the css and javascript links are relative. With SEF & .htaccess enabled this causes the template to attempt to load these files relative to the current path. These paths map to the component and Joomla tries to map them to a page and outputs HTML instead of the desired CSS file.

To recreate this bug:
Create a new Joomla install with Protostar as default template and no content

  1. Enable SEF links via the global settings & copy htaccess.txt to .htaccess in web root
  2. Create a new article in the admin site (id should be 1)
  3. Manually enter the article name via the url siteurl/component/content/article/1

Please note that the SEF plugin has to be disabled to reproduce this.

@infograf768
Copy link
Member

looks fine to me.

@Bakual Bakual added this to the Joomla! 3.4.0 milestone Nov 21, 2014
@Bakual
Copy link
Contributor

Bakual commented Nov 21, 2014

Merged, thanks!

@Bakual Bakual closed this in 46a7e90 Nov 21, 2014
pmorrisarctg added a commit to ArcTechnologyGroup/joomla-cms that referenced this pull request Nov 26, 2014
staging

# By Michael Babker (143) and others
# Via infograf768 (131) and others
* 'staging' of https://github.com/joomla/joomla-cms: (1128 commits)
  Fixed typo introduced on PR joomla#4308
  Fixed missing space
  Correcting comments
  [fix joomla#5173] JRouterInstallation::build() strict standards
  trim the author and created_by_alias before saving
  Remove all \r\n
  Update en-GB.plg_system_debug.ini
  JRouterInstallation::parse() made compatible with the interface (Fix
joomla#5173)
  Clean up non-printable characters.
  Fixed creationDate
  Fixes Author and Copyright info for Editor - None
  Routing: Implementing an interface for component router rules (Fix
joomla#4849)
  Routing: Adding application and menu objects to component routers (Fix
joomla#4848)
  Fixing JGithub repository contents api (Fix joomla#5067)
  [bug] Protostar template doesn't work with component links in SEF.
Fixes joomla#5085
  Fix undefined variable in Article Model
  ... use the right variable, dummy.
  fix the codemirror display bug, happens when codemirror is initialized
in a hidden element.
  Use the created_by_alias in the author meta tag. This is consistent
with how author name is show elsewhere.
  [fix] Broken groups management by joomla#4308
  ...

Conflicts:
	installation/sql/sqlazure/sample_blog.sql
	installation/sql/sqlazure/sample_testing.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants