Load menus before triggering before and after delete events #5458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Menu objects aren't being loaded before triggering before and after delete events.
Consequences
With #4308 changes, we are now triggering events on Menu delete actions. If the object isn't loaded before triggering these events, the data being passed to the handlers is incomplete.
Test instructions
At this point the catcher plugin will raise a message for each event that got triggered. Without the patch, the menu data that gets passed to the event handler is missing (only ID is available in the after delete event). With the patch included in this PR, all the menu data is made available to the handlers, i.e. id, menutype, title and description.
Thank you in advance for considering this PR.