Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language files for components updated to match style guidelines. #6094

Merged
merged 11 commits into from
Mar 23, 2015

Conversation

Duke3D
Copy link
Contributor

@Duke3D Duke3D commented Feb 15, 2015

References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.

Trademark indicia added to references to the JED.

References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
Trademark indicia added to references to the Joomla! Extensions Directory.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point.  Usability / accessibility outweighs any trademark benefit.
@infograf768
Copy link
Member

We are in language freeze. Imho this should not be merged until 3.4.1.

@brianteeman
Copy link
Contributor

This is part of the work of the en-GB working group and will be followed by further PR for plugins and modules shortly. Removing the ! does not effect translations and is part of the agreed work that PLT has already approved can be committed and as agreed is being deliberately submitted after the language freeze.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6094.

@infograf768
Copy link
Member

sigh...

@Hils
Copy link
Contributor

Hils commented Feb 15, 2015

For the very many translators using eg Transifex as their preferred tool to prepare translations for Joomla before submission to the official team, this has a great effect on translations.

For example Joomla! is a different word from Joomla and is treated as such.

Several official translators have already packaged their languages for 3.4 and I think it is our job to make things less disruptive for translators by waiting until after 3.4 release.

@brianteeman
Copy link
Contributor

This is a PLT decision

On 15 February 2015 at 12:56, Hils notifications@github.com wrote:

For the very many translators using eg Transifex as their preferred tool
to prepare translations for Joomla before submission to the official team,
this has a great effect on translations.

For example Joomla! is a different word from Joomla and is treated as
such.

Several official translators have already packaged their languages for 3.4
and I think it is our job to make things less disruptive for translators by
waiting until after 3.4 release.


Reply to this email directly or view it on GitHub
#6094 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Hils
Copy link
Contributor

Hils commented Feb 15, 2015

I do not believe PLT would decide to do this if they understood how translators work. When was this decision made please? and where? Was it a decision by the whole PLT which included people who understand translating as, for example, @Bakual does?

@Hils
Copy link
Contributor

Hils commented Feb 15, 2015

Further information that might be useful:
As a result of #5615 ,
from the 8333 total lines to be translated for 3.4, 1849 had to be edited, after the language freeze.

@brianteeman
Copy link
Contributor

Hils - that was the agreement made and it was done at the request of the PLT and the TT co-ordinator AFTER the language freeze. It was ready a month before the freeze but the TT co-ordinator requested that it was NOT merged until after the freeze.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6094.

@Bakual
Copy link
Contributor

Bakual commented Feb 15, 2015

PLT decided to merge #5615 after language freeze so JM can do diffs and share them with the teams.
This was done in agreement with JM and translators were informed about it.

There was no decision made for following PRs. My understanding was that the referenced PR was complete for stage1 and that further PRs will be done after 3.4.0 is released.

I certainly don't want to merge more language strings at this time, short before RC.

However I agree with the standardising and we will likely merge it shortly after 3.4.0 is released. Giving translators enough time to update their strings.

@brianteeman
Copy link
Contributor

OK I am closing this PR and will close the WG - you win again and we go
back to the dark ages

On 15 February 2015 at 13:25, Thomas Hunziker notifications@github.com
wrote:

PLT decided to merge #5615
#5615 after language freeze so
JM can do diffs and share them with the teams.
This was done in agreement with JM and translators were informed about it.

There was no decision made for following PRs. My understanding was that
the referenced PR was complete for stage1 and that further PRs will be done
after 3.4.0 is released.

I certainly don't want to merge more language strings at this time, short
before RC.

However I agree with the standardising and we will likely merge it shortly
after 3.4.0 is released. Giving translators enough time to update their
strings.


Reply to this email directly or view it on GitHub
#6094 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Hils
Copy link
Contributor

Hils commented Feb 15, 2015

Factual discussion is constructive. @Bakual has said that 'they will likely merge it shortly after 3.4.0 is released'. Why can't this PR, which we all seem to agree with, wait? What has closing it achieved?

@Bakual
Copy link
Contributor

Bakual commented Feb 15, 2015

Huh? Reopening since I still think this is a valid PR.

@Bakual Bakual reopened this Feb 15, 2015
@ot2sen
Copy link
Contributor

ot2sen commented Feb 15, 2015

The cosmetic style changes here do have an impact on the work the Fellow volunteers in the translation area will have. More of the tools they use to assist on automatically merging and updating source to target language changes, will reset a full string in most cases.
While it is good on quality that the individual teams are forced to review any core source language changes, still such cosmetic style changes in last minute mean that 40 strings will have to be redone for all 60 languages.

Would be reasonable to wait until after release in a case like this.
Adding an example of how removing one ! in source will bring work to any team of the full string where the ! was removed.
joomlatest_after
joomlatest_before

@Duke3D
Copy link
Contributor Author

Duke3D commented Feb 17, 2015

While there is some urgency to get a style guide in place, which Brian has done great job in coordinating, I see no reason that implementation in the language files cannot wait until 3.4.1 My apologies if this PR was premature - there was to intention to disrupt the TT teams. Implementation for the en-gb files served as a good test whether the style rules were complete enough to address the actual language stings in use, without ambiguity, before we go to the next step of translating the rules themselves.

@Bakual Bakual added this to the Joomla! 3.4.1 milestone Feb 17, 2015
@Bakual Bakual added the RTC This Pull Request is Ready To Commit label Feb 17, 2015
@Bakual
Copy link
Contributor

Bakual commented Feb 17, 2015

Set to RTC and added the 3.4.1 milestone. Thanks Duke!

@phproberto
Copy link
Contributor

Merged. Thanks!

Bakual pushed a commit that referenced this pull request Mar 14, 2015
Sorry guys. We're still in language freeze for Joomla 3.4.1.
This commit will be reapplied when the language freeze is either lifted or 3.4.1 is released.
@Bakual
Copy link
Contributor

Bakual commented Mar 14, 2015

Sorry guys. Had to temporary revert this commit because we are still in language freeze for Joomla 3.4.1.
We will reapply it once 3.4.1 is released.

@brianteeman
Copy link
Contributor

sad

On 14 March 2015 at 09:28, Thomas Hunziker notifications@github.com wrote:

Sorry guys. Had to temporary revert this commit because we are still in
language freeze for Joomla 3.4.1.
We will reapply it once 3.4.1 is released.


Reply to this email directly or view it on GitHub
#6094 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@brianteeman
Copy link
Contributor

So is this going to be re-opened or are we now going to completely ignore anything that you dont like to have in joomla. And no I dont believe that you are going to commit it after 3.4.1 - it was already promised for 3.4.1 when you made the last useless language freeze.
Seriously the language freeze is a joke. Did it result in even a majority of translations being ready

@phproberto
Copy link
Contributor

Sorry if I caused the confusion. I saw it in the v3.4.1 milestone after the discussion about including it or not and I thought it was decided.

@brianteeman
Copy link
Contributor

It was decided but no one carried out the decision :(

On 14 March 2015 at 14:47, Roberto Segura notifications@github.com wrote:

Sorry if I caused the confusion. I saw it in the v3.4.1 milestone after
the discussion about including it or not and I thought it was decided.


Reply to this email directly or view it on GitHub
#6094 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@mbabker mbabker reopened this Mar 14, 2015
@mbabker mbabker modified the milestones: Joomla! 3.4.2, Joomla! 3.4.1 Mar 14, 2015
@mbabker
Copy link
Contributor

mbabker commented Mar 14, 2015

Reopened and assigned to 3.4.2 milestone. @wilsonge when you do your post release merge frenzy, merge this.

@Bakual
Copy link
Contributor

Bakual commented Mar 14, 2015

So is this going to be re-opened

I would just have applied it again after release, but reopening sure works as well.

rdeutz added a commit that referenced this pull request Mar 23, 2015
Language files for components updated to match style guidelines.
@rdeutz rdeutz merged commit 5955705 into joomla:staging Mar 23, 2015
@Bakual Bakual added the Language Change This is for Translators label Apr 14, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.