-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language files for components updated to match style guidelines. #6094
Conversation
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit. Trademark indicia added to references to the Joomla! Extensions Directory.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
We are in language freeze. Imho this should not be merged until 3.4.1. |
This is part of the work of the en-GB working group and will be followed by further PR for plugins and modules shortly. Removing the ! does not effect translations and is part of the agreed work that PLT has already approved can be committed and as agreed is being deliberately submitted after the language freeze. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6094. |
sigh... |
For the very many translators using eg Transifex as their preferred tool to prepare translations for Joomla before submission to the official team, this has a great effect on translations. For example Joomla! is a different word from Joomla and is treated as such. Several official translators have already packaged their languages for 3.4 and I think it is our job to make things less disruptive for translators by waiting until after 3.4 release. |
This is a PLT decision On 15 February 2015 at 12:56, Hils notifications@github.com wrote:
Brian Teeman |
I do not believe PLT would decide to do this if they understood how translators work. When was this decision made please? and where? Was it a decision by the whole PLT which included people who understand translating as, for example, @Bakual does? |
Further information that might be useful: |
Hils - that was the agreement made and it was done at the request of the PLT and the TT co-ordinator AFTER the language freeze. It was ready a month before the freeze but the TT co-ordinator requested that it was NOT merged until after the freeze. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6094. |
PLT decided to merge #5615 after language freeze so JM can do diffs and share them with the teams. There was no decision made for following PRs. My understanding was that the referenced PR was complete for stage1 and that further PRs will be done after 3.4.0 is released. I certainly don't want to merge more language strings at this time, short before RC. However I agree with the standardising and we will likely merge it shortly after 3.4.0 is released. Giving translators enough time to update their strings. |
OK I am closing this PR and will close the WG - you win again and we go On 15 February 2015 at 13:25, Thomas Hunziker notifications@github.com
Brian Teeman |
Factual discussion is constructive. @Bakual has said that 'they will likely merge it shortly after 3.4.0 is released'. Why can't this PR, which we all seem to agree with, wait? What has closing it achieved? |
Huh? Reopening since I still think this is a valid PR. |
While there is some urgency to get a style guide in place, which Brian has done great job in coordinating, I see no reason that implementation in the language files cannot wait until 3.4.1 My apologies if this PR was premature - there was to intention to disrupt the TT teams. Implementation for the en-gb files served as a good test whether the style rules were complete enough to address the actual language stings in use, without ambiguity, before we go to the next step of translating the rules themselves. |
Set to RTC and added the 3.4.1 milestone. Thanks Duke! |
Merged. Thanks! |
Sorry guys. We're still in language freeze for Joomla 3.4.1. This commit will be reapplied when the language freeze is either lifted or 3.4.1 is released.
Sorry guys. Had to temporary revert this commit because we are still in language freeze for Joomla 3.4.1. |
sad On 14 March 2015 at 09:28, Thomas Hunziker notifications@github.com wrote:
Brian Teeman |
So is this going to be re-opened or are we now going to completely ignore anything that you dont like to have in joomla. And no I dont believe that you are going to commit it after 3.4.1 - it was already promised for 3.4.1 when you made the last useless language freeze. |
Sorry if I caused the confusion. I saw it in the v3.4.1 milestone after the discussion about including it or not and I thought it was decided. |
It was decided but no one carried out the decision :( On 14 March 2015 at 14:47, Roberto Segura notifications@github.com wrote:
Brian Teeman |
Reopened and assigned to 3.4.2 milestone. @wilsonge when you do your post release merge frenzy, merge this. |
I would just have applied it again after release, but reopening sure works as well. |
Language files for components updated to match style guidelines.
References to Joomla in mid-sentence should not include the exclamation point. Usability / accessibility outweighs any trademark benefit.
Trademark indicia added to references to the JED.