Syntax errors in file /com_admin/sql/updates/mysql/3.4.0-2014-09-16.sql

[wojsmol]

PR for issue #8786
Original issue description

IMHO file https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.4.0-2014-09-16.sql contains MySQL syntax errors :
is

ALTER TABLE `#__redirect_links` ADD header smallint(3) NOT NULL DEFAULT 301;
ALTER TABLE `#__redirect_links` MODIFY new_url varchar(255);

should be

ALTER TABLE `#__redirect_links` ADD `header` smallint(3) NOT NULL DEFAULT 301;
ALTER TABLE `#__redirect_links` MODIFY `new_url` varchar(255);

related: #6333

[wojsmol]

Travis returns errors, but from what I see they are not related to this PR.

[wojsmol]

Additionaly see #6333 (comment)

[Bakual]

Did you get a MySQL error while updating from a version before 3.4.0? To my knowledge, the SQL commands work fine and apparently nobody had a problem since we released 3.4.0.

[ggppdk]

I had to run the query manually in the past

ALTER TABLE `#__redirect_links` ADD header smallint(3) NOT NULL DEFAULT 301;

About this fix,

• i tested it has the same effect as fixing JSchemaChangeitemMysql to detect "ADD columnname"
  After changing the SQL file, the Database view (extension manager) reported the missing column, and Fix button worked

I manually deleted the header column from the redirect_links

Without Fix:

With change in the SQL file, missing column is detected

and notice that now the reported DB changes are 80 instead of 79:

[wilsonge]

Merged on review. Whilst not everyone seemed to hit this - the syntax in here is definitely more correct in terms of escaping the column names. And the column thing definitely is required for the schema here https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/schema/changeitem/mysql.php#L66